Skip to content

[DOCS] Fix hard-coded links to master #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2025
Merged

[DOCS] Fix hard-coded links to master #4813

merged 1 commit into from
Feb 3, 2025

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 31, 2025 •
edited
Loading

Description

Relates to elastic/docs#3160

This PR fixes the following type of documentation build error, which occurs when we retire the master documentation:

INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/observability/8.6/whats-new.html contains broken links to:
--
  | INFO:build_docs:   - en/kibana/master/opsgenie-action-type.html

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Relates to elastic/docs#3160

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@lcawl lcawl added the backport-skip Skip notification from the automated backport with mergify label Jan 31, 2025
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@github-actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@lcawl lcawl marked this pull request as ready for review January 31, 2025 01:28
@lcawl lcawl requested a review from a team as a code owner January 31, 2025 01:28
kilfoyle
kilfoyle approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦞

@lcawl lcawl merged commit 47eb9d1 into elastic:8.6 Feb 3, 2025
5 checks passed
@lcawl lcawl deleted the master-links branch February 3, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees

No one assigned

Labels

backport-skip Skip notification from the automated backport with mergify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lcawl @kilfoyle